Feature/barriers - #4
Merged
Merged
Conversation
- Scenarios except reverse barrier KOs now have rtol of 0.015
…iate - Replace UnsupportedFeatureError with ValidationError for incompatible pricing engine/greek calc method
- Also add checks for int type attrs
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Passing in a float now raises
…lidation - MC barrier: inception-hit (continuous + discrete), discrete/continuous rebate paths, and non-barrier-aware LSM basis - Binomial barrier: explicit monitoring_dates, Boyle-Lau cap-bind warning, KI/KO triggered-at-inception PV - BarrierSpec: enum type guards and strike-none validation - Params: for_barriers classmethod smoke tests (defaults, overrides, invalid override rejection)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify anchor_spot behavior in the PDE barrier solver, tighten American barrier Greek tolerances, fix the control-variate guard to allow barrier use where intended, add for_barriers class methods to binomial and PDE params, update README, add -n auto to dev locked CI job