Flatten pane header action buttons#230
Merged
Merged
Conversation
Replace the pill container around the pane header's new-tab and pane-actions buttons with a flat group plus a 1px vertical divider between them, matching the flatter toolbar look. Visual-only change; button behaviour is unchanged. The shared chromeControlsGroupStyle pill is kept on the back/forward navigation group.
jsgrrchg
force-pushed
the
simplify-pane-buttons
branch
from
9d5d2b2 to
9b300e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Flattens the pane header's action button group (the "new tab"
+and"pane actions"
⋮). The group used to sit inside a rounded pill(
chromeControlsGroupStyle: background + border + shadow). Now it's aflat, transparent group with a thin 1px vertical divider between the two
buttons.
Why
Matches the flatter toolbar treatment we wanted for these buttons — the
pill read heavier than the surrounding chrome.
Scope
+stillopens the quick switcher (right-click → new-tab menu) and
⋮stillopens the pane actions menu.
chromeControlsGroupStylepill is left untouched and stillapplies to the back/forward navigation group.
Verification
eslint: cleantsc -b: no type errorsEditorPaneBar.test.tsx: 25/25 passing