Skip to content

[Snyk] Security upgrade hono from 4.12.14 to 4.12.16 - #173

Closed
jscraik wants to merge 2 commits into
mainfrom
snyk-fix-d61a998726535483ba9a074e358a02f6
Closed

[Snyk] Security upgrade hono from 4.12.14 to 4.12.16#173
jscraik wants to merge 2 commits into
mainfrom
snyk-fix-d61a998726535483ba9a074e358a02f6

Conversation

@jscraik

@jscraik jscraik commented May 16, 2026

Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the pnpm dependencies of this project.

Snyk changed the following file(s):

  • platforms/mcp/package.json
⚠️ Warning
Failed to update the pnpm-lock.yaml, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Allocation of Resources Without Limits or Throttling
SNYK-JS-HONO-16438966
  721  
low severity HTML Injection
SNYK-JS-HONO-16438965
  401  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b39aa91e-0064-42f2-ba81-4c787559b145

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch snyk-fix-d61a998726535483ba9a074e358a02f6

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e91e8a9092

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"dependencies": {
"@modelcontextprotocol/sdk": "^1.26.0",
"hono": "^4.12.14",
"hono": "^4.12.16",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate lockfile for hono upgrade

Bumping hono in platforms/mcp/package.json without updating pnpm-lock.yaml leaves the workspace lock pinned to hono 4.12.14 in the platforms/mcp importer, so the vulnerable version is still what gets installed in lockfile-driven environments. This also risks CI failures because repository workflows install with pnpm install --frozen-lockfile (checked in .github/workflows/ci.yml lines 66, 232, 322, and 428), which requires the lockfile to match manifest changes.

Useful? React with 👍 / 👎.

@jscraik

jscraik commented Jun 20, 2026

Copy link
Copy Markdown
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
🔚 Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@jscraik

jscraik commented Jun 20, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded by current main. While resolving this PR, origin/main already contains a newer patched MCP hono version (platforms/mcp/package.json uses ) and matching pnpm-lock.yaml entries (). Branch-diff proof from the rebase checkout showed and , so this PR has no remaining unique change to land.

@jscraik jscraik closed this Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants