fix(capture): fix window crop on stacked displays - #195
Merged
Merged
Conversation
`SCContentFilter.pointPixelScale` reports the main display's scale for a window on a display arranged above the primary one, because such a display has a negative Y origin in the global CoreGraphics space. On a 2x built-in with a 1x external above it that yields 2.0 instead of 1.0, so the stream was configured at twice the size ScreenCaptureKit renders and the recording gained blank padding to the right of and below the content. Resolve a window's scale from the display it actually occupies instead, and set `scalesToFit` for window captures: independent window capture is the one mode where the configured width and height are only a buffer size, not a resize instruction. Closes #190
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCContentFilter.pointPixelScalereports the main display's scale for a window on a display arranged above the primary one, because such a display has a negative Y origin in the global CoreGraphics space. On a 2x built-in with a 1x external above it that yields 2.0 instead of 1.0, so the stream was configured at twice the size ScreenCaptureKit renders and the recording gained blank padding to the right of and below the content.Resolve a window's scale from the display it actually occupies instead, and set
scalesToFitfor window captures: independent window capture is the one mode where the configured width and height are only a buffer size, not a resize instruction.AI usage: Opus 5; Used AI to analyze and fix the bug.
Closes #190