fix: preserve static asset link extensions#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
../static/rfc-001/*.png.mdfallback, and document indexesRegression
docuchango validatein 1.18.1 appended.mdto every relative link target that did not already end in.md. That made valid asset links such as../static/rfc-001/hcp-vault-radar-architecture.pngresolve as../static/rfc-001/hcp-vault-radar-architecture.png.md, producing false broken-link errors. Version 1.18.0 did not report those asset links as broken.This PR keeps the intended fallback for extensionless document links, but only when the cleaned local path has no suffix. Links that already point at concrete files such as
.png,.svg, or other assets are validated as-is.Lateral Checks
.mdsuffix?queryand#fragmentvalidate against the underlying file%20, validate against decoded filesystem paths.mdTests
uv run --python 3.13 --extra test python -m pytest tests/test_link_validation.py tests/test_document_indexes.py