Bundle Vice.Host into the Vice package#7
Merged
Merged
Conversation
Library consumers that build their own CLI need the hosting layer (ViceApp / ViceAppBuilder), which lives in Vice.Host. Host is an internal partition (RootNamespace=Vice, IsPackable=false) like Foundation and Jobs, so bundle its assembly into the Vice package rather than publishing it separately. Host cannot be a project reference of Vice (it references Vice, which would cycle), so resolve and bundle it at pack time via GetTargetPath and require the solution to be built first. install-local.sh now builds the solution before packing so the bundled Host assembly is present. Bump to 0.1.2. Generated with Claude Code is what they want you to think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library consumers that build their own Vice CLI need the hosting layer (
ViceApp/ViceAppBuilder), which lives inVice.Host. After the restructure the publishedVicepackage lets you define commands but not construct/run an app, becauseVice.HostisIsPackable=falseand unpublished.Vice.Hostis an internal partition (RootNamespace=Vice, only depends on Vice/Jobs/Foundation) like Foundation and Jobs, so this bundles its assembly into theVicepackage rather than publishing it separately. Host can't be a project reference ofVice(it referencesVice→ cycle), so it's resolved and bundled at pack time viaGetTargetPath, requiring the solution to be built first.install-local.shnow builds the solution before packing. Bumped to 0.1.2.Verified: packed
Vice.0.1.2.nupkgdepends only onVice.Parser 0.1.2and bundlesVice.dll,Vice.Foundation.dll,Vice.Jobs.dll,Vice.Host.dllinlib/net10.0.🤖 Generated with Claude Code