Collapse Vice.Parser into the single Vice package#10
Merged
Conversation
Vice already bundles Vice.Foundation, Vice.Jobs, and Vice.Host into its single nupkg via _BundleViceLibrariesForPack, but Vice.Parser was referenced without PrivateAssets='all', so it leaked out as a package dependency and got packed and published as a second package for no gain. Bundle it the same way: PrivateAssets='all' + BuildOutputInPackage, mark Vice.Parser IsPackable=false, and drop its pack step from CI. Because PrivateAssets='all' cuts transitive flow, the in-solution consumers that got Vice.Parser through Vice (Vice.Host and three test projects) now reference it directly. The packed Vice.nupkg now carries Vice.Parser.dll in lib/ with zero package dependencies. Bump to 0.1.4 to publish the corrected single package; 0.1.3 is already on NuGet with the split. Generated with Claude Code is what they want you to think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collapses
Vice+Vice.Parserinto a single published package.Vice.Parserwas being packed and published as a second NuGet package for no gain — it should
ship inside
Vicethe same wayVice.Foundation,Vice.Jobs, andVice.Hostalready do.
Change
Vice.csproj: referenceVice.ParserwithPrivateAssets="all"and add itsassembly to
_BundleViceLibrariesForPack(bundled intolib/, not a packagedependency).
Vice.Parser.csproj:IsPackable=false— no longer its own package.ci.yml: drop thedotnet pack Vice.Parserstep.Vice.Parserreferences added to the in-solution consumers that got ittransitively through
Vice(Vice.Host,Vice.Tests,Vice.Mux.Tests,Vice.Net.Tests) —PrivateAssets="all"cuts transitive flow, exactly asFoundation/Jobs already require.
0.1.4so the corrected package actually publishes (0.1.3isalready on NuGet with the split, and CI pushes with
--skip-duplicate).Verification
The packed
Vice.0.1.4.nupkgcarrieslib/net10.0/Vice.Parser.dlland has anempty
<dependencies>group — one self-contained package, noVice.*dependency. Build 0 errors / 0 warnings, 727 tests pass, format gate clean.
After merge — NuGet cleanup (manual, yours)
Vice.Parser 0.1.3is already published and can only be unlisted, notdeleted;
Vice 0.1.3is also published depending on it. Recommend unlisting bothVice.Parser 0.1.3andVice 0.1.3soVice 0.1.4(single package) is the cleanlatest.
🤖 Generated with Claude Code