Fix items identified by MDL Shield - #720
Open
jrchamp wants to merge 6 commits into
Open
Conversation
smbader
approved these changes
Jul 9, 2026
smbader
left a comment
smbader
left a comment
Collaborator
There was a problem hiding this comment.
The changes look great!
Owner
Author
|
@sgrandh3 Did you have any questions from the testing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some very nice proactive improvements in our security posture, based on recommendations from a MDL Shield review. It's a very nice tool that noticed some things and provided helpful suggestions that led to action. I'm sure there are still opportunities for improvement, but the benefits to users easily outweigh the small amount of effort needed to run the report and implement appropriate changes.