lib: events are visible when the module is visible to the user - #717
Merged
Conversation
smbader
approved these changes
May 28, 2026
smbader
left a comment
smbader
left a comment
Collaborator
There was a problem hiding this comment.
As mentioned, this really feels like the work Moodle core should do. This function seems like a place to alter or extend the check in unusual ways if the plugin needed to.
Smart code, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw the suggestion in #716 that we should be implementing
course_calendar_is_event_visible. The part that I don't understand is why Moodle doesn't run a generic version of this code itself. Maybe some events are intended to be visible to everyone? Please double check that this actually does the right thing. It seems correct, perhaps a bit overly safe, but I'd rather start with safe. Feel free to suggest changes of course.Fixes #716