fix: remove deprecated FEATURE_GROUPMEMBERSONLY from zoom_supports() - #715
Merged
Merged
Conversation
Contributor
Author
|
I was going to do a more robust version that checks the moodle branch value (>=503) but it actually turns out that FEATURE_GROUPMEMBERSONLY has asctually been deprecated since Moodle 2.8! |
Collaborator
|
Michael, Thank you for such a well written and explained issue/pull request. Much appreciated! |
smbader
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
case FEATURE_GROUPMEMBERSONLY:fromzoom_supports()inlib.php.Fixes #714
Problem
The
FEATURE_GROUPMEMBERSONLYconstant has been deprecated in Moodle 5.3 (MDL-83231). In Moodle 5.3+, the upgrade process throws aplugin_defective_exceptionif a module's_supports()function returnstruefor'groupmembersonly', rendering the plugin broken and blocking upgrades.Change
One line removed from
zoom_supports()inlib.php:- case FEATURE_GROUPMEMBERSONLY:Note:
FEATURE_GROUPINGSis not deprecated and is unchanged.Moodle versions affected
Moodle 5.3+ (main branch)