Skip to content

fix: remove deprecated FEATURE_GROUPMEMBERSONLY from zoom_supports() - #715

Merged
smbader merged 1 commit into
jrchamp:mainfrom
University-of-Strathclyde-LTE-Team:GH-714
May 15, 2026
Merged

fix: remove deprecated FEATURE_GROUPMEMBERSONLY from zoom_supports()#715
smbader merged 1 commit into
jrchamp:mainfrom
University-of-Strathclyde-LTE-Team:GH-714

Conversation

@michael-hughes-strath

Copy link
Copy Markdown
Contributor

Summary

Removes case FEATURE_GROUPMEMBERSONLY: from zoom_supports() in lib.php.

Fixes #714

Problem

The FEATURE_GROUPMEMBERSONLY constant has been deprecated in Moodle 5.3 (MDL-83231). In Moodle 5.3+, the upgrade process throws a plugin_defective_exception if a module's _supports() function returns true for 'groupmembersonly', rendering the plugin broken and blocking upgrades.

Change

One line removed from zoom_supports() in lib.php:

-        case FEATURE_GROUPMEMBERSONLY:

Note: FEATURE_GROUPINGS is not deprecated and is unchanged.

Moodle versions affected

Moodle 5.3+ (main branch)

@michael-hughes-strath

Copy link
Copy Markdown
Contributor Author

I was going to do a more robust version that checks the moodle branch value (>=503) but it actually turns out that FEATURE_GROUPMEMBERSONLY has asctually been deprecated since Moodle 2.8!

@smbader

smbader commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Michael,

Thank you for such a well written and explained issue/pull request. FEATURE_GROUPMEMBERSONLY seems to have been just hanging around quietly for a 11 years. Also, thanks for bringing this to our attention before release!

Much appreciated!
Steve

@smbader smbader added the bug Fixes problems or reduces technical debt label May 15, 2026
@smbader smbader moved this to Has Pull Request in mod_zoom Workflow May 15, 2026
@smbader
smbader merged commit 5897983 into jrchamp:main May 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes problems or reduces technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zoom_supports() declares FEATURE_GROUPMEMBERSONLY which is deprecated and breaks Moodle 5.3

2 participants