behat: configure during step; javascript is unnecessary - #710
Merged
Conversation
At this time, the view_meeting Behat test does not require the @javascript tag and should therefore not include it. The generator class was setting configuration, which prevented values set in the Behat feature file from being used. Fun side note: the mod_zoom plugin is saving all of its configuration settings using the outdated naming convention (without the mod_ prefix). Reference: https://moodledev.io/docs/5.2/apis/subsystems/admin "activity modules should use 'mod_mymodule/setting' instead of 'mymodule/setting'"
Owner
Author
|
Performance comparison based on recent CI runs for arguably the simplest Behat test ever (something to be proud of!):
|
cbounphengsy
approved these changes
Apr 16, 2026
cbounphengsy
left a comment
cbounphengsy
left a comment
Contributor
There was a problem hiding this comment.
Setting the config values in a more Behat way seems like the logical move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this time, the view_meeting Behat test does not require the
@javascripttag and should therefore not include it. The generator class was setting configuration, which prevented values set in the Behat feature file from being used.Fun side note: the mod_zoom plugin is saving all of its configuration settings using the outdated naming convention (without the mod_ prefix). Moodle's developer documentation has included a note about this since May 2015:
Looks like it was primarily using the modern frankenstyle name until #214. Meanwhile, look how naive I was in early 2021: #180 (comment) 😅