Skip to content

ci: use recommended mobileapp template folder (requires Moodle 3.8) #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrchamp wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: use recommended mobileapp template folder (requires Moodle 3.8) #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07004d1
ci: use recommended mobileapp template folder
jrchamp Feb 16, 2026
4329c48
Mobile app: Remove ionic3 template
dpalou Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ jobs:
env:
DB: ${{ matrix.database }}
MOODLE_BRANCH: ${{ matrix.moodle-branch }}
MUSTACHE_IGNORE_NAMES: 'mobile_view_page_latest.mustache,mobile_view_page_ionic3.mustache'
# Uncomment this to run Behat tests using the Moodle App.
# MOODLE_APP: 'true'

Expand Down
3 changes: 1 addition & 2 deletions classes/output/mobile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ public static function mobile_course_view($args) {
global $OUTPUT, $DB;

$args = (object) $args;
$versionname = $args->appversioncode >= 3950 ? 'latest' : 'ionic3';
$cm = get_coursemodule_from_id('zoom', $args->cmid);

// Capabilities check.
Expand Down Expand Up @@ -85,7 +84,7 @@ public static function mobile_course_view($args) {
'templates' => [
[
'id' => 'main',
'html' => $OUTPUT->render_from_template("mod_zoom/mobile_view_page_$versionname", $data),
'html' => $OUTPUT->render_from_template('mod_zoom/mobileapp/view_page', $data),
],
],
'javascript' => "this.loadMeeting = function(result) { window.open(result.joinurl, '_system'); };",
Expand Down
118 changes: 0 additions & 118 deletions templates/mobile_view_page_ionic3.mustache
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion templates/mobile_view_page_latest.mustache → templates/mobileapp/view_page.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template mod_zoom/mobile_view_page_latest
@template mod_zoom/mobileapp/view_page

Page to view a zoom meeting

Expand Down