Skip to content

lib: call grade reset when zoom reset userdata is checked - #700

Merged
smbader merged 2 commits into
mainfrom
fix/gradereset
Apr 9, 2026
Merged

lib: call grade reset when zoom reset userdata is checked#700
smbader merged 2 commits into
mainfrom
fix/gradereset

Conversation

@smbader

@smbader smbader commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator

There are two options in the course reset that we need to support.

The first is when the grade reset for the course is checked. This should be handled already with our existing zoom_reset_gradebook function.

The second is when zoom specific reset option is checked which reads, "Delete all user grades, recording user view data, and meeting participant user data." In this case, we were not reseting grades. So this pull requests adds zoom_reset_gradebook to that function. Since it's a nuclear checkbox that does all, we don't need to check for $data->reset_gradebook_grades

Fixes #693

@smbader smbader self-assigned this Feb 12, 2026
@smbader smbader added the bug Fixes problems or reduces technical debt label Feb 12, 2026
@smbader

smbader commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator Author

Testing Need:

  • Create Zoom activities that are graded.
  • Perform the course reset grade checkbox: "All grades" and verify Zoom activity grades are reset.

Then check:

  • Create Zoom activities that are graded.
  • Only check the Zoom reset option: "Delete all user grades, recording user view data, and meeting participant user data."
  • Verify Zoom grades have been reset.

@smbader
smbader requested a review from sgrandh3 February 12, 2026 16:37
Comment thread lib.php
@smbader

smbader commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator Author

@sgrandh3 will test one final time and if all is well, please feel free to hit the approve button.

@sgrandh3

sgrandh3 commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator

Checked the "Delete all user grades, recording user view data, and meeting participant user data." checkbox in the course reset . Grades were cleared as expected.

@armccoy
armccoy self-requested a review April 9, 2026 15:11

@armccoy armccoy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@smbader
smbader merged commit ac668a7 into main Apr 9, 2026
12 checks passed
@smbader
smbader deleted the fix/gradereset branch April 9, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes problems or reduces technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reset might not reset grades

4 participants