Skip to content

fix(us-275): autoMode must not skip planning Steps 1–3 - #276

Merged
jpolvora merged 5 commits into
mainfrom
develop
Sep 4, 2026
Merged

fix(us-275): autoMode must not skip planning Steps 1–3#276
jpolvora merged 5 commits into
mainfrom
develop

Conversation

@jpolvora

@jpolvora jpolvora commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fail-closed validate_state.cjs --pre-advance 4 now requires plan-of-record artifacts, completed/skipped steps 1–3, and prints HS-5 with missing paths before any Step 4 dispatch.
  • Documents autoMode ≠ skip planning in ws-spec-to-pr plus child-slug / init-banner rules in gates.md and setup.md.
  • Contract tests cover the Step 0-only autoMode fixture (NS1) and doc tables (AC1–AC8).

Closes #275

Test plan

  • npm run test
  • Mechanical gates: check_duplicates, measure_harness, check_shell_quoting, check_pipeline_handoff
  • Fixture: missing step-01 / plan.index.json--pre-advance 4 non-zero with HS-5

…pped

autoMode still auto-selects gate index 0 only; --pre-advance 4 now requires
plan artifacts and HS-5 before any Step 4 dispatch.
Comment thread .agents/skills/ws-spec-to-pr/STEP-DISPATCH.md Outdated
Comment thread .agents/skills/ws-spec-to-pr/STEP-DISPATCH.md Outdated
Comment thread .agents/skills/ws-spec-to-pr/SKILL.md Outdated
Comment thread .agents/skills/ws-shared/scripts/workflow_state.cjs Outdated
Comment thread test/test-workflow-state-contract.js
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

agentic-code-reviewers v0.4.0 (cursor-sdk)

Automatic review state — Round: 3 / 10

Comment thread test/test-quality-gates.js
Comment thread .agents/skills/ws-shared/scripts/workflow_state.cjs
…T_kwDOTFajc86fJkoa, PRRT_kwDOTFajc86fJko0, PRRT_kwDOTFajc86fJkpZ, PRRT_kwDOTFajc86fJkqA]
Comment thread .agents/skills/ws-shared/scripts/workflow_state.cjs
Comment thread test/test-workflow-state-contract.js
…T_kwDOTFajc86fJ2yL, PRRT_kwDOTFajc86fJsWf, PRRT_kwDOTFajc86fJsXA]
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

agentic-code-reviewers v0.4.0 (cursor-sdk)

All pending issues have been successfully resolved! The PR is ready to be merged. 🚀

@jpolvora
jpolvora merged commit f5ce26c into main Sep 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ws-spec-to-pr: orquestrador implementou sem plano/refino — autoMode não deve pular Steps 1–3

1 participant