Use global Request type to prevent type errors - #70
Merged
Conversation
• build: { minify: true } causes variable names to be mangled in the SSR build of the app, which means that Models will have the wrong name and will wind up pointing at non-existent (or wrong) D1 tables
• v3_lazyRouteDiscovery is a new default behavior for remix that doesn’t require any other changes to enable
you need to pass the --remote flag to the newest version of wrangler’s migrations apply command in order to get it to run on the production instance of the D1 DB
also, upgrade from v3.6.1 → v3.8.0 (latest)
this resolves a type error that was being triggered when using handleFetch<env>(request, …) from a worker.ts script (e.g. in examples/remix-cms). the full TS error:
worker.ts:17:37 - error TS2345: Argument of type 'Request<unknown, IncomingRequestCfProperties<unknown>>' is not assignable to parameter of type 'import("/Users/andrew/Projects/superflare/node_modules/.pnpm/@cloudflare+workers-types@4.20241018.0/node_modules/@cloudflare/workers-types/index").Request<unknown, import("/Users/andrew/Projects/superflare/node_modules/.pnpm/@cloudflare+workers-types@4.20241018.0/node_modules/@cloudflare/workers-types/index").Incomi...'.
The types of 'clone().headers' are incompatible between these types.
Property 'getAll' is missing in type 'Headers' but required in type 'import("/Users/andrew/Projects/superflare/node_modules/.pnpm/@cloudflare+workers-types@4.20241018.0/node_modules/@cloudflare/workers-types/index").Headers'.
17 return await handleFetch<Env>(request, env, ctx, config, handleRequest);
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is branched off of #69 (which is branched off of #68) and removes all usage of the
Request<unknown, IncomingRequestCfProperties<unknown>>type. at one point during work on #66, using that type resolved issues with the version of@cloudflare/workers-typesavailable at that time and with usage of superflare’shandleFetchfrom the mainworker.tsscript, but that is no longer the case. in fact, these types are now causing the following TS error (from runningtscin theexamples/remix-cmsworkspace):updating
requesttype annotations to use the globally availableRequesttype without any generics resolves the issue.