github: Use ming-action v8 - #387
Merged
Merged
Conversation
jp7677
force-pushed
the
mingw-action
branch
3 times, most recently
from
August 4, 2026 18:51
57786ef to
a8e5e9f
Compare
jp7677
marked this pull request as ready for review
August 4, 2026 19:07
Saancreed
approved these changes
Aug 4, 2026
Saancreed
left a comment
Saancreed
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but see the comments.
No need to use master anymore, Wine dependencies are resolved. As a side effect, no more AUR packages in the build process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to use master anymore, Wine dependencies are resolved. As a side effect, no AUR packages in the build process anymore. So essentially dropping the last 4 commits from https://github.com/misyltoad/arch-mingw-github-action/commits/master/
While at it, update catch2 and also declare a function static.