This repository was archived by the owner on Jul 23, 2019. It is now read-only.
C# library added - #423
Closed
fluiddot wants to merge 1 commit into
Closed
Conversation
caseyahenson
suggested changes
Apr 21, 2017
Contributor
There was a problem hiding this comment.
@fluiddot nice work on this! With the release of 3.0, emoji strategy is now keyed by 'unicode' (which is actually base code point/file name) instead of shortname. Please account for this in your .map function in generate.js as well as in your .cs file.
Also note that previously the "shortname" key was not wrapped in a : where the attribute is now in that form, so you'll want to strip those out in your map as well.
Once that's done I'll go ahead and merge this.
Author
|
Closing this PR as it's updated in #594 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple C# lib with a ShortnameToUnicode method to get unicode strings from shortnames.