🧪 testing improvement: Add verify_pull_request test coverage - #81
🧪 testing improvement: Add verify_pull_request test coverage#81joy7758 wants to merge 3 commits into
Conversation
Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98a96757e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| task = self.write_task(request, "exhaust-task.json") | ||
| evidence = self.write_evidence(request, "exhaust-evidence.json") | ||
|
|
||
| with self.assertRaises(RuntimeError): |
There was a problem hiding this comment.
Whenever this test runs, the patched constructor raises RuntimeError for summary.md during both the requested-output reservation and every private fallback attempt. verify_pull_request catches the first error, while reserve_private() catches the next eight and ultimately raises UnsafePathError, so this assertRaises(RuntimeError) fails and breaks the required unit-test check. Either make the mock fail only for the initial reservation or expect the final UnsafePathError.
AGENTS.md reference: AGENTS.md:L50-L58
Useful? React with 👍 / 👎.
Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
…ting Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
1 participant
🎯 What: The untested function
verify_pull_requestinpr_gate.pyhas now been covered by dedicated test cases.📊 Coverage: The new tests cover multiple branches, including missing parameters, output reservation handling (FileExistsError, UnsafePathError etc.), mutation handling, and directory safety.
✨ Result: Test coverage improved across the board. Edge cases for pull request output mutations are now tested securely.
PR created automatically by Jules for task 11184459664589839012 started by @joy7758