🧹 Refactor _verify_package_control_files to reduce argument count - #59
🧹 Refactor _verify_package_control_files to reduce argument count#59joy7758 wants to merge 3 commits into
_verify_package_control_files to reduce argument count#59Conversation
Extract expected_manifest and expected_attestation generation to caller `verify_worker_package` to reduce the number of parameters of `_verify_package_control_files` from 8 down to 4. Also use direct `worker` dict instead of passing `workers` collection and `expected_worker` id to improve encapsulation. Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…njection.py` and `service.py` Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
🎯 What: Addressed "Too Many Arguments" (PLR0913) code health issue in
_verify_package_control_files.💡 Why: By reducing the arguments from 8 down to 4, we improve maintainability and readability, while maintaining exact backward compatibility in function behavior.
✅ Verification: Verified by passing tests locally, confirming
PLR0913is no longer firing for this function, and successfully reading over the caller changes.✨ Result: Improved code health in
skill_materialization.pyby simplifying the method signatures.PR created automatically by Jules for task 3724376421403793332 started by @joy7758