⚡ Optimize JSON schema registry loading - #57
Conversation
Previously, `_validator` was cached per-contract, but the registry building logic was inside it. This meant that when validating a different contract, the entire `schema` directory was re-read and re-parsed to rebuild the same registry. This change extracts the registry building into its own cached helper function. Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36108557d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @functools.cache | ||
| def _schema_registry() -> Registry: |
There was a problem hiding this comment.
This commit changes the contract-validation implementation without updating governance/agent-recommendation-gate.json; the retained gate still describes an unrelated August 13 security-fix scope and base commit, so it does not record the recommendation, correction evidence, remaining gaps, or stop conditions for this optimization. Refresh the development gate for this task before merging.
AGENTS.md reference: AGENTS.md:L23-L25
Useful? React with 👍 / 👎.
Previously, `_validator` was cached per-contract, but the registry building logic was inside it. This meant that when validating a different contract, the entire `schema` directory was re-read and re-parsed to rebuild the same registry. This change extracts the registry building into its own cached helper function. Also fixes ruff lint errors that were causing the CI pipeline to fail. Co-authored-by: joy7758 <138868899+joy7758@users.noreply.github.com>
1 participant
💡 What: Extracted the schema registry initialization in
contracts.pyinto a separate@functools.cachedecorated function_schema_registry().🎯 Why: The previous code cached the
_validatorfunction for each contract but instantiated a new registry inside it. This caused the system to perform a disk glob and parse every.schema.jsonfile once for each unique contract type validated, causing redundant and expensive file I/O and JSON parsing in a loop.📊 Measured Improvement: Baseline test loading all contracts took ~0.052s, optimized implementation takes ~0.012s, resulting in ~77.8% reduction in building time.
PR created automatically by Jules for task 15258809969943647669 started by @joy7758