Skip to content

rtnl module fixes #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jow- merged 3 commits into from
Jul 9, 2026
+3 −3
Merged

rtnl module fixes #418

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d256e15
rtnl: fix stack buffer overflow parsing IFLA_LINKINFO
nbd168 Jul 7, 2026
f741ac0
rtnl: fix stack buffer overflow parsing RTA_MULTIPATH nexthops
nbd168 Jul 7, 2026
c41310f
rtnl: fix inverted address check in multipath nexthop parsing
nbd168 Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/rtnl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,7 +1563,7 @@ uc_nl_parse_rta_nexthop(struct nl_msg *msg, uc_vm_t *vm, uc_value_t *val)
if (ucv_type(val) != UC_OBJECT)
return false;

if (uc_nl_parse_cidr(vm, ucv_object_get(val, "via", NULL), &cidr))
if (!uc_nl_parse_cidr(vm, ucv_object_get(val, "via", NULL), &cidr))
return false;

aflen = (cidr.family == AF_INET6 ? sizeof(cidr.addr.in6) : sizeof(cidr.addr.in));
Expand Down Expand Up @@ -1679,7 +1679,7 @@ uc_nl_convert_rta_multipath(const uc_nl_attr_spec_t *spec, struct nl_msg *msg, s
nh_obj = ucv_object_new(vm);
ucv_array_push(nh_arr, nh_obj);

nla_parse(multipath_tb, RTA_MAX + 1, (struct nlattr *)RTNH_DATA(nh), nh->rtnh_len - sizeof(*nh), NULL);
nla_parse(multipath_tb, RTA_MAX, (struct nlattr *)RTNH_DATA(nh), nh->rtnh_len - sizeof(*nh), NULL);

if (multipath_tb[RTA_GATEWAY]) {
switch (nla_len(multipath_tb[RTA_GATEWAY])) {
Expand Down Expand Up @@ -1992,7 +1992,7 @@ uc_nl_convert_rta_linkinfo_data(uc_value_t *obj, size_t attr, struct nl_msg *msg
static uc_value_t *
uc_nl_convert_rta_linkinfo(const uc_nl_attr_spec_t *spec, struct nl_msg *msg, struct nlattr **tb, uc_vm_t *vm)
{
struct nlattr *linkinfo_tb[IFLA_INFO_MAX];
struct nlattr *linkinfo_tb[IFLA_INFO_MAX + 1];
uc_value_t *info_obj, *slave_obj;

if (!tb[spec->attr])
Expand Down
Loading