ubus: fix reply leak in deferred data callback#415
Open
cmonroe wants to merge 1 commit into
Open
Conversation
blob_array_to_ucv() returns the reply with a reference count of 1 owned by uc_ubus_call_data_user_cb(). Pushing it onto the VM stack with an extra ucv_get() leaves that owning reference unreleased after the callback returns and leaks the entire reply object on every data callback invocation. Signed-off-by: Chad Monroe <chad@monroe.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blob_array_to_ucv() returns the reply with a reference count of 1 owned by uc_ubus_call_data_user_cb(). Pushing it onto the VM stack with an extra ucv_get() leaves that owning reference unreleased after the callback returns and leaks the entire reply object on every data callback invocation.