nlbwmon: fix db cleanup - #44
Open
feckert wants to merge 1 commit into
Open
Conversation
Owner
|
You should only call |
The database will only be cleaned up when the daemon is restarted. With this change, each refresh of the database checks whether the artifacts should be cleaned up from the past database. Thus, no more than configured are kept. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
feckert
force-pushed
the
pr/20210301-fix-db-cleanup
branch
from
March 2, 2021 11:21
5d91e8f to
5adf900
Compare
Author
|
@jow- ping |
|
@jow- ping... :-) |
|
database_archive() can also be called from handle_event(), in which case it will not return -ESTALE in refresh and database_cleanup() get skipped. I've put database_cleanup() inside database_archive(), see here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jow- The database will only be cleaned up when the daemon is restarted. With
this change, each refresh of the database checks whether the artifacts
should be cleaned up from the past database. Thus, no more than
configured are kept.
This fixes openwrt/packages#14297