Institutional-grade execution-analytics figures#1
Open
joshfinney wants to merge 1 commit into
Open
Conversation
Replace ad-hoc dark-themed / radar plots with a clean, buy-side-ready figure suite driven off the eval data. Adds: - viz/style.py: shared light-theme matplotlib rcParams, a validated hero/recessive palette (PPO accent; muted baselines), distinct markers/linestyles as secondary encoding, and bps axis formatting. - experiments/collect_raw.py: per-episode costs + sample trajectories. - experiments/plots.py: five figures — execution efficiency frontier (cost vs risk), implementation-shortfall distribution, mean cost by regime with error bars, 95% VaR tail-risk league table, and the execution schedule. PNG (README) + SVG (vector) output. - eval.py --figures flag and README Results section with embedded charts. All costs reported in basis points (bps), the standard TCA unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the previous ad-hoc, dark-themed / radar-style plots with a clean, buy-side-ready figure suite generated directly from the eval data. The old charts were never committed; this adds a proper, reproducible plotting module.
Why the old plots read as "vibe-coded"
What's here now
Five figures (
experiments/plots.py), all in basis points, light theme, one accent for the hero policy (PPO), muted-gray baselines, with markers + line styles as secondary encoding (survives greyscale / CVD):Palette validated with the dataviz colour checker (CVD separation ΔE 38.5, well clear of the floor).
Story the charts tell
TWAP posts the lowest mean cost, but PPO delivers the best risk-adjusted execution — roughly half the cost dispersion and the lowest tail risk (VaR) in every regime.
Structure
viz/style.py— shared theme (palette, rcParams, bps formatter)experiments/collect_raw.py— per-episode costs + trajectoriesexperiments/plots.py— figure generation (PNGfor README +SVGvector)eval.py --figuresflag; README Results section with embedded chartsReproduce:
uv run python experiments/plots.py. Tests still green (8 passed); ruff clean.🤖 Generated with Claude Code