Skip to content

fix(network_preflight): guard skipped fallback DNS probe result - #20

Merged
joshavant merged 1 commit into
mainfrom
fix/network-preflight-effective-dns-probe
Mar 19, 2026
Merged

fix(network_preflight): guard skipped fallback DNS probe result#20
joshavant merged 1 commit into
mainfrom
fix/network-preflight-effective-dns-probe

Conversation

@joshavant

@joshavant joshavant commented Mar 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • avoid selecting network_preflight_dns_resolution_after_fallback when the fallback probe task was skipped
  • require a real fallback probe result (rc present) before using it as the effective DNS probe
  • add a regression assertion in logic tests to keep this guard in place

Root Cause

network_preflight_dns_resolution_after_fallback is still defined when its task is skipped, but that skipped result does not include rc. The previous selector treated "defined" as sufficient, and later conditionals accessed .rc, causing provisioning to fail during DNS preflight.

Testing

  • python3 -m pytest -q tests/logic_py/test_docs.py -k network_preflight
  • python3 -m pytest -q tests/logic_py

@joshavant
joshavant merged commit 9887f38 into main Mar 19, 2026
3 checks passed
@joshavant
joshavant deleted the fix/network-preflight-effective-dns-probe branch March 19, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant