[joseluisll]

No description provided.

[joseluisll]

@OpenHands please fix the errors reported by the failing check.

[openhands-ai]

I'm on it! joseluisll can track my progress at all-hands.dev

[openhands-ai]

Summary

I fixed the failing CI check for PR #3 "Fix initialize forgeapp streaming". The issue was a mypy type error in skyvern/forge/forge_app.py:

skyvern/forge/forge_app.py:271: error: Item "None" of "StreamingService | None" has no attribute "start_monitoring"  [union-attr]
skyvern/forge/forge_app.py:275: error: Item "None" of "StreamingService | None" has no attribute "stop_monitoring"  [union-attr]

Root Cause

The STREAMING_SERVICE attribute is typed as StreamingService | None. Even though the code checked if app.STREAMING_SERVICE: before defining the inner closure functions, mypy couldn't infer that app.STREAMING_SERVICE would still be non-None when the closures are eventually called.

Fix

Captured the streaming service in a local variable before defining the closures, allowing mypy to properly narrow the type:

if app.STREAMING_SERVICE:
    # Capture the streaming service in a local variable for the closures
    streaming_service = app.STREAMING_SERVICE

    async def _startup_event(fastapi_app: FastAPI) -> None:
        streaming_service.start_monitoring()  # Now uses local variable

    async def _shutdown_event() -> None:
        await streaming_service.stop_monitoring()  # Now uses local variable

Verification

• ✅ mypy check passes locally
• ✅ Changes are minimal and focused on fixing the type error
• ✅ Pushed to the fix-initialize-forgeapp-streaming branch

The fix has been pushed and should trigger a new CI run that passes the pre-commit hooks.

View full conversation