Migrate to WaniKani API v2#12
Conversation
|
@padarom Thanks for the PR! I'll have a look and merge in the next few days. I don't use wanikani these days, and I haven't looked at this code in years, except for incoming PRs. It's likely due for an overhaul and/or a new maintainer. |
|
Any update on this? I'd love to continue being able to use this awesome extension. |
|
FYI, Pulled this and ran locally, can confirm change seems to be working (Admittedly Brave Browser) but I can't see why it wouldn't for Chrome. |
|
Yeah, sadly does not appear to be working on chrome. Installed @padarom fork. |
|
I'm not sure what I'm missing then. Tried a fresh install of Brave Browser as well, and didn't work there either for me. Any ideas, or any form of debugging/logs I can help with? Edit: Figured out the how to get the console to log stuff. Looks like I'm getting an incomplete promise due to the GET URL being wrong for some reason. Log attached |
|
The difference seems to be our Wanikani progress. The request attaches all subject IDs that you have at your minimum SRS level as GET parameters. For me and wiilover22 this seems fine because we don't have as many subjects, but for you it seems like the parameters make the URL exceed the maximum URL length supported by WaniKani. Unfortunately I don't have the time right now to look into this, but I assume we'd need to split the request in |

API v1 will cease to exist on September 1. Therefore Wanikanify needs to migrate to v2 in order to keep functioning from that date on.
The endpoints in v2 are more atomic in nature, so unfortunately it's not quite as easy to use as v1 but I tried to make the code as readable as possible.