Skip to content

Adds exclude_dev and allow_list config options#64

Open
gavg-vaioni wants to merge 2 commits into
jorijn:masterfrom
gavg-vaioni:master
Open

Adds exclude_dev and allow_list config options#64
gavg-vaioni wants to merge 2 commits into
jorijn:masterfrom
gavg-vaioni:master

Conversation

@gavg-vaioni

Copy link
Copy Markdown

The Enlightn SecurityChecker has options for excluding dev dependencies from checks and specifying an allow list of permitted vulnerabilities. This change exposes these options to this package by way of two optional config entries:

  • exclude_dev
  • allow_list

Copilot AI review requested due to automatic review settings June 17, 2026 09:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adds configurable checker options (excluding dev dependencies and an allow list) to the security-check commands and updates tests/configuration to validate and expose the new behavior.

Changes:

  • Pass exclude_dev and allow_list config values into SecurityChecker::check() across console commands.
  • Tighten Mockery expectations in tests to assert the command passes the configured options.
  • Add new config keys (exclude_dev, allow_list) and corresponding tests.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/TestCase.php Updates mock expectations to require checker options are passed.
tests/SecuritySlackCommandTest.php Adds test covering configured checker options for Slack command.
tests/SecurityMailCommandTest.php Adds test covering configured checker options for email command.
tests/SecurityCommandTest.php Adds test covering configured checker options for the main command.
src/Console/SecuritySlackCommand.php Passes exclude_dev and allow_list to check().
src/Console/SecurityMailCommand.php Passes exclude_dev and allow_list to check().
src/Console/SecurityCommand.php Passes exclude_dev and allow_list to check().
config/laravel-security-checker.php Adds exclude_dev and allow_list configuration entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread config/laravel-security-checker.php
Comment thread config/laravel-security-checker.php
Comment thread config/laravel-security-checker.php Outdated
Comment thread tests/SecurityCommandTest.php
Comment thread tests/SecuritySlackCommandTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants