Adds exclude_dev and allow_list config options#64
Open
gavg-vaioni wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds configurable checker options (excluding dev dependencies and an allow list) to the security-check commands and updates tests/configuration to validate and expose the new behavior.
Changes:
- Pass
exclude_devandallow_listconfig values intoSecurityChecker::check()across console commands. - Tighten Mockery expectations in tests to assert the command passes the configured options.
- Add new config keys (
exclude_dev,allow_list) and corresponding tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/TestCase.php | Updates mock expectations to require checker options are passed. |
| tests/SecuritySlackCommandTest.php | Adds test covering configured checker options for Slack command. |
| tests/SecurityMailCommandTest.php | Adds test covering configured checker options for email command. |
| tests/SecurityCommandTest.php | Adds test covering configured checker options for the main command. |
| src/Console/SecuritySlackCommand.php | Passes exclude_dev and allow_list to check(). |
| src/Console/SecurityMailCommand.php | Passes exclude_dev and allow_list to check(). |
| src/Console/SecurityCommand.php | Passes exclude_dev and allow_list to check(). |
| config/laravel-security-checker.php | Adds exclude_dev and allow_list configuration entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Enlightn SecurityChecker has options for excluding dev dependencies from checks and specifying an allow list of permitted vulnerabilities. This change exposes these options to this package by way of two optional config entries: