Fix for Build ID conflicts - disabling build id generation - #2147
Open
rathboma wants to merge 1 commit into
Open
Fix for Build ID conflicts - disabling build id generation#2147rathboma wants to merge 1 commit into
rathboma wants to merge 1 commit into
Conversation
rpmbuild generates .build-id symlinks under /usr/lib/.build-id/ by default. When multiple packages include pre-built ELF binaries with identical build-ids (common with Electron apps bundling the same Chromium libraries), these symlinks conflict at install time. Since FPM packages pre-built binaries rather than source-compiled ones, these build-id links serve no useful purpose. This adds %define _build_id_links none to the spec template, consistent with how FPM already disables other rpmbuild post-processing defaults. Users who need build-id links can override with: --rpm-rpmbuild-define '_build_id_links compat' Fixes jordansissel#2142
Owner
|
Thanks for working on this! Regarding Claude, the copyright aspects are unclear to me (and to current case law in the US?). Given that, I'm not comfortable accepting this PR. That said, I am in favor of eliminating the build id files in rpm outputs. I'll take a look at implementing that soon; and fortunately, removing the build id is a pretty simple change <3 |
Owner
|
I’ll take a look at this again shortly. It’s small enough that I can probably evaluate it and move forward :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full disclosure: This fix is generated by Claude. I did review it and did a bit of research on the purpose of Build IDs. Seems like they're mostly used for debugging, and it doesn't really hurt to remove them in FPM's case?
This adds %define _build_id_links none to the spec template, consistent with how FPM already disables other rpmbuild post-processing defaults.
Users who need build-id links can override with:
--rpm-rpmbuild-define '_build_id_links compat'
Fixes #2142