Handle fully transparent average colors - #967
Open
offyotto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An image with no pixels at or above the alpha threshold leaves the included pixel count at zero.
averageColorthen divides by zero and returns a color containingNaNcomponents.Return
nilwhen no pixels qualify. The existing menu bar and Ice Bar callers already handle a missing average color.Test:
xcodebuild -project Ice.xcodeproj -scheme Ice -configuration Debug -derivedDataPath /tmp/IceDerivedData CODE_SIGNING_ALLOWED=NO build(BUILD SUCCEEDED)