Change journal mode from WAL to DELETE - #339
Open
antnorwe wants to merge 1 commit into
Open
Conversation
Owner
|
Hi, thanks! My only worry here is the reduced concurrency support in DELETE mode. Let me do a little testing with this setting, will come back with my findings. |
Author
|
Thanks for the quick response! If that remains a concern, maybe this could be added as an optional env variable so that we can choose to take the risk? |
Owner
Fine by me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an SMB/CIFS share as the location of the volume, the SQLite DB cannot correctly intialise due to file locking errors:
Another project that uses SQLite had a similar issue, and the proposed fix was their solution:
https://github.com/charmbracelet/crush/pull/1280/changes
Therefore submitting here to achieve the same outcome of allowing me to store data on a mounted SMB/CIFS drive