Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/python_overseerr/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from __future__ import annotations

from dataclasses import dataclass, field
from datetime import date, datetime # noqa: TC003
from datetime import date, datetime
from enum import IntEnum, IntFlag, StrEnum
from typing import Annotated

Expand All @@ -12,6 +12,13 @@
from mashumaro.types import Discriminator


def deserialize_optional_date(value: str | None) -> date | None:
"""Deserialize an optional date, treating an empty string as None."""
if value is None or value == "":
return None
return date.fromisoformat(value)


@dataclass
class RequestCount(DataClassORJSONMixin):
"""Request count model."""
Expand Down Expand Up @@ -120,7 +127,12 @@ class TV(Result):
"""TV result model."""

mediaType = ResultMediaType.TV # noqa: N815 # pylint: disable=invalid-name
first_air_date: date = field(metadata=field_options(alias="firstAirDate"))
first_air_date: date | None = field(
metadata=field_options(
alias="firstAirDate",
deserialize=deserialize_optional_date,
)
)
name: str
original_language: str = field(metadata=field_options(alias="originalLanguage"))
original_name: str = field(metadata=field_options(alias="originalName"))
Expand Down
41 changes: 41 additions & 0 deletions tests/test_overseerr.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
OverseerrError,
)
from python_overseerr.models import (
TV,
IssueStatus,
IssueType,
NotificationType,
Expand Down Expand Up @@ -224,6 +225,46 @@ async def test_search(
)


async def test_search_with_empty_tv_first_air_date(
responses: aiointercept,
client: OverseerrClient,
) -> None:
"""Test searching for a TV result with an empty first air date."""
responses.get(
f"{MOCK_URL}/search?query=unknown",
status=200,
body="""{
"page": 1,
"totalPages": 1,
"totalResults": 1,
"results": [
{
"id": 123,
"firstAirDate": "",
"genreIds": [],
"mediaType": "tv",
"name": "Unknown",
"originCountry": ["US"],
"originalLanguage": "en",
"originalName": "Unknown",
"overview": "",
"popularity": 0,
"voteAverage": 0,
"voteCount": 0,
"backdropPath": null,
"posterPath": null
}
]
}""",
)

results = await client.search("unknown")

assert len(results) == 1
assert isinstance(results[0], TV)
assert results[0].first_air_date is None


async def test_search_with_encoded_spaces(
responses: aiointercept, client: OverseerrClient
) -> None:
Expand Down
Loading