Repository navigation
Add poster_path, backdrop_path and release_date to Movie/TV models - #487
Merged
felixschndr merged 3 commits intoOct 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Search results (
Movie,TV) and detail lookups (MovieDetails,TVDetails) don't expose poster/backdrop images, even though the API returns them.Moviealso doesn't expose a release date, even thoughMovieDetailsalready does.Confirmed against the existing test fixtures (
tests/fixtures/*/search_1.json,search_2.json,movie.json,tv.json) —posterPath,backdropPath, and (for search results)releaseDateare all present in real API responses, just not modeled.Change
Movie,TV: addposter_path/backdrop_path(optional —posterPathis frequentlynullin practice).Movie: addrelease_date(date | None). The API can send""rather than omitting the field when unknown, so this uses the samedeserialize_optional_dateapproach Handle empty TV first air dates #496 added forTV.first_air_date, treating an empty string asNoneinstead of failingdate.fromisoformat.MovieDetails,TVDetails: addposter_path/backdrop_pathfor the same reason.Testing
--snapshot-update); diff is purely additive/type-representation only — no existing fields changed or removed, aside fromMovie.release_datenow showing asdatetime.date(...)/Noneinstead of a raw string.release_datecase is already exercised by the existingsearch_1.json/search_2.jsonfixtures (e.g. "Frosty"), so no new fixture was needed — reverting the deserializer causes those existing tests to fail withValueError: Invalid isoformat string: '', not just a snapshot mismatch.ruff,pylint, andmypyall pass locally.