Skip to content

Added MAX_PASSAGE_LENGTH and missing deps mlx and psutil#4

Open
olafgeibig wants to merge 1 commit into
joonsoome:mainfrom
olafgeibig:passage-len-config
Open

Added MAX_PASSAGE_LENGTH and missing deps mlx and psutil#4
olafgeibig wants to merge 1 commit into
joonsoome:mainfrom
olafgeibig:passage-len-config

Conversation

@olafgeibig

Copy link
Copy Markdown

I made the passage length configurable because the rag tool that I'm using, LightRAG, uses much bigger documents than 4096. The default in env.example is still set to 4096. Additionally, I added MLX and PSUtil to the dependencies, since I could not build without them.

@joonsoome joonsoome added the enhancement New feature or request label Oct 24, 2025
@joonsoome

Copy link
Copy Markdown
Owner

I made the passage length configurable because the rag tool that I'm using, LightRAG, uses much bigger documents than 4096. The default in env.example is still set to 4096. Additionally, I added MLX and PSUtil to the dependencies, since I could not build without them.

@olafgeibig Thank you so much for your contribution! There are a few issues in the current version that I’d like you to check and address if possible. I also plan to test it with LightRAG, probably sometime after November this year. If I find similar symptoms or other areas for improvement, I’ll update it accordingly!

@olafgeibig

Copy link
Copy Markdown
Author

Sorry, In was very busy and now I see that the PR can not be merged. You want to address the issue anyway... If you want me to contribute, what shall I do?

@joonsoome

Copy link
Copy Markdown
Owner

Sorry, In was very busy and now I see that the PR can not be merged. You want to address the issue anyway... If you want me to contribute, what shall I do?

No problem! Please contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants