This repository was archived by the owner on Nov 28, 2017. It is now read-only.
Changed according to com_content - #9
Open
sovainfo wants to merge 1 commit into
Open
Conversation
sovainfo
commented
May 26, 2014
- Removed useless comments, they say the same thing as the statements themselves!
- Only use variables when used more than once
- Removed useless comments, they say the same thing as the statements themselves! - Only use variables when used more than once
|
@sovainfo Thanks for PR. What I think is that it will be good to leave detailed code for explanation purpose. I mean at expert level it is easy to understand but on fresher level it's hard to understand code in one line without code comments. |
Contributor
|
@sovainfo thanks for the PR. My apologies for missing it! I do like the idea of having best practices followed here. The changes at https://github.com/joomla/Joomla-3.2-Hello-World-Component/pull/9/files#diff-75947db5b8755a95db8e179de97bff6dR13 do seem good to me. @gunjanpatel what are your thoughts of that change, if accompanying notes are left in place? |
|
@betweenbrain That's good. np. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.