Skip to content
This repository was archived by the owner on Nov 28, 2017. It is now read-only.

Changed according to com_content - #9

Open
sovainfo wants to merge 1 commit into
joomla:step-10-adding-decorations-to-the-backendfrom
sovainfo:patch-1
Open

Changed according to com_content#9
sovainfo wants to merge 1 commit into
joomla:step-10-adding-decorations-to-the-backendfrom
sovainfo:patch-1

Conversation

@sovainfo

Copy link
Copy Markdown
  • Removed useless comments, they say the same thing as the statements themselves!
  • Only use variables when used more than once

- Removed useless comments, they say the same thing as the statements themselves!
- Only use variables when used more than once
@gunjanpatel

Copy link
Copy Markdown

@sovainfo Thanks for PR. What I think is that it will be good to leave detailed code for explanation purpose. I mean at expert level it is easy to understand but on fresher level it's hard to understand code in one line without code comments.

@betweenbrain

Copy link
Copy Markdown
Contributor

@sovainfo thanks for the PR. My apologies for missing it!

I do like the idea of having best practices followed here. The changes at https://github.com/joomla/Joomla-3.2-Hello-World-Component/pull/9/files#diff-75947db5b8755a95db8e179de97bff6dR13 do seem good to me.

@gunjanpatel what are your thoughts of that change, if accompanying notes are left in place?

@gunjanpatel

Copy link
Copy Markdown

@betweenbrain That's good. np. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants