CHI/Test.pm: Replace manual import stuff with Import::Into#18
Open
kentfredric wants to merge 2 commits into
Open
CHI/Test.pm: Replace manual import stuff with Import::Into#18kentfredric wants to merge 2 commits into
kentfredric wants to merge 2 commits into
Conversation
This is partially motivated by the fact Test::More is changing its exporter. CHI Test exposes this fact presently due to reaching into exporter internals, causing a breakage when they cease to exist. This change changes import syntax to use defined public import API to perform imports.
Unfortunately, Phase order happens as such: - Add Files. - Remove Files - Munge Files - Finalise Installer https://metacpan.org/source/RJBS/Dist-Zilla-5.023/lib/Dist/Zilla/Dist/Builder.pm#L317 Which means without this patch, it does: GatherDir ( Imports Makefile.PL from disk ) MakeMaker ( Injects a templated Makefile.PL ) PruneFiles ( Removes both of the above ) MakeMaker ( Attempts to munge previously injected Makefile.PL and bails when it doesn't exist ) This patch resolves that by removing the problem file before it even gets added to dzil, eliminating conflict.
Author
|
Seems the contributors readme is a bit out of date and you've got tidyall stuff. However, the tidyall stuff doesn't appear to work, and its perltidy settings seem to be completely ignored. I've manually run perltidy on the code I submittied with the params from tidyall, and I hope the result is adequate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partially motivated by the fact Test::More is changing its
exporter.
CHI Test exposes this fact presently due to reaching into exporter internals,
causing a breakage when they cease to exist. ( Test-More/test-more#472 )
This change changes import syntax to use defined public import API to
perform imports.
And I figure that's less-ugly.
I'm not 100% certain I've done the translation correct, but CHI' passes its own tests like this.