SS6.1.10: error in FileAdmin

[wernerkrauss]

Hi @jonom, in SS6.1.10 I get the following error when clicking on a file in file Admin:

ERROR [Emergency]: Uncaught Error: Call to a member function getX() on null
IN GET /admin/assets/schema/fileEditForm/3
Line 85 in /var/www/html/vendor/jonom/focuspoint/src/Forms/FocusPointField.php

Source
======
  76:              $w = intval($this->config()->get('max_width'));
  77:              $h = intval($this->config()->get('max_height'));
  78:              $previewImage = $this->image->FitMax($w * 2, $h * 2);
  79:  
  80:              if ($previewImage) {
  81:                  $state['data'] += [
  82:                      'previewUrl' => $previewImage->getURL(),
  83:                      'previewWidth' => $previewImage->getWidth(),
  84:                      'previewHeight' => $previewImage->getHeight(),
* 85:                      'X' => $this->image->getField($this->getName())->getX(),
  86:                      'Y' => $this->image->getField($this->getName())->getY()
  87:                  ];
  88:              }
  89:          }
  90:  
  91:          return $state;

This is, cause the name of the field is not set properly. I debugged it and it gets lost in a parent class; Then getName() returns the title (wich is "Focus point") with stripped space; Then the image doesn't find the correct field...

A possible fix is to change the last two lines in FocusPointField::__construct()... first call parent::__construct(), then set the name again.

[wernerkrauss]

See #116 which already addressed this issue

[jonom]

Not sure why I wasn't able to replicate that issue. Is this OS-specific maybe? What version of PHP are you using? It doesn't seem like the issue is affecting many people if there hasn't been any activity on that PR in the last 2 years.

[Dennisprins93]

Same here. PHP8.5 with SS 6.2. I for now fixed it with a composer patch