sync canvas-kit to 2026-07-07.4 (SSRF redirect guard, schema validation, safe storage) - #21
Closed
jongio wants to merge 1 commit into
Closed
sync canvas-kit to 2026-07-07.4 (SSRF redirect guard, schema validation, safe storage)#21jongio wants to merge 1 commit into
jongio wants to merge 1 commit into
Conversation
…on, safe storage) Re-vendor the canonical canvas-kit into all six example extensions, advancing the vendored copy from 2026-07-05.1 to 2026-07-07.4. This pulls the latest hardening from the create-canvas-app kit: - net: re-check the SSRF guard on every redirect hop - server: cap concurrent SSE subscribers per instance - storage: session-scoped paths + safe atomic saves - validate/runtime: stricter action input validation The stricter input validation surfaced two smoke tests that asserted against the old kit's looser behavior. Update them to the current contract with no behavior change in the extensions themselves: - code-tutor: an out-of-enum clear_cache level is now rejected by the kit's schema gate (the message names the allowed values) before the handler's own guard runs; loosen the assertion and refresh the now-stale comment. - wiki-discover: rating the current card omits `article` instead of passing `article: undefined` (a real client drops undefined keys over JSON, and the kit now type-checks a present-but-undefined optional object). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Re-vendors the canonical
canvas-kitinto all six example extensions, advancing the vendored copy from 2026-07-05.1 → 2026-07-07.4:Each extension's
canvas-kit/is now a byte-for-byte mirror of the currentcreate-canvas-appkit (verified with the kit freshness check).Why
The vendored kit was two point releases behind the canonical kit and missed recent hardening from the Copilot host app's canvas kit:
30x).Test compatibility (no extension behavior change)
The stricter input validation surfaced two smoke tests that asserted against the old kit's looser behavior. Both were updated to the current contract; the extensions' runtime behavior is unchanged:
clear_cachelevelis now rejected by the kit's schema gate (its message names the allowed values) before the handler's own guard runs. The concept is still protected from deletion; only the error-message text moved. Loosened the assertion (/must be one of/) and refreshed the now-stale "kit does no schema validation" comment.articleinstead of passingarticle: undefined. A real client dropsundefinedkeys during JSON serialization, and the kit now type-checks a present-but-undefined optional object.Verification (local, mirrors CI's
validatejob)node scripts/lint.mjs→ clean (87.mjs, 15.json)node scripts/validate-extensions.mjs→ 6 extensions validnode scripts/run-tests.mjs→ all 6 test files passcheck-kit-freshness.mjs→ all 6 vendored kits fresh at2026-07-07.4Note
This is intentionally not a pure version bump — it also carries the two small test-compatibility edits above — so it is flagged for a quick review rather than auto-merged.