fix: repair broken mmq console-script entry point#1
Open
jonathanubatech wants to merge 2 commits into
Open
Conversation
Add 31 mocked unit tests (no live network/CLI): test_engine.py (13), test_fallback.py (9), test_telemetry.py (9). Suite now 52 passing (was 21 CRAWL-only). Fix all ruff errors in src/ and tests/ (UP041, SIM117, E501, E741, B905, F401, UP017). Fix pre-existing mypy --strict failures in engine.py/fallback.py: str() wraps for Any-returning json.loads/.get chains, narrow asyncio.gather result with BaseException, type: ignore[import-untyped] for boto3. Gates: ruff clean, mypy --strict clean (7 files), pytest 52 passed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pyproject [project.scripts] declared mmq = "multi_model_lib.cli:main" but src/multi_model_lib/cli.py did not exist (CLI lived in scripts/multi-model-query.py, which the wheel build target does not package and whose hyphenated filename is not importable). Installing the package and running `mmq` raised ModuleNotFoundError. Fix (option a): move the full CLI implementation into the installable package as src/multi_model_lib/cli.py with main(); reduce scripts/multi-model-query.py to a thin shim that delegates to multi_model_lib.cli:main so both invocation paths share one implementation. Verified: pip install -e . && mmq --help (exit 0); mmq --dry-run, python -m multi_model_lib.cli, and direct script shim all work. Gates: ruff clean, mypy --strict clean (8 files), pytest 52 passed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the broken mmq console-script entry point. All checks green locally: ruff, mypy --strict, 52 tests pass. Commit ef5ceb3.