fix: note indexing, wikilink creation, current-file tracking, ripgrep error handling, inbox review, tree refresh, and colon-title links#5
Merged
Conversation
Owner
|
Great work here @guitmz! I went through the fixes - you fixed a bunch of things I missed! The regression tests are are thorough and so very welcomed, too - this helped me track the fixes here. Can you rebase this PR before it gets merged? Much appreciated! |
Contributor
Author
|
@jonathanchu rebase done :) I was early stages in the process of writing a similar package for myself so I had gone already through some design decisions that made a bit easier to find the things in this PR |
Owner
|
Appreciate this! Thank you @guitmz ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 KBare indexed correctly (see benchmark notes below).:as valid Grove wikilinks instead of misclassifying them as standard org protocol links.[[https://...]]and[[file:...]].rgis missing orripgrepexecution fails, instead of silently returning an empty result set.1as "no matches" rather than an execution failure.Benchmark note: I measured the new whole-file parser against the previous
4 KBlimited behavior on synthetic org files. The current parser took about0.47 msfor a64 KiBnote,6.48 msfor a1 MiBnote, and33.88 msfor a5 MiBnote. An initial cache refresh across50 x 1 MiBnotes took328 mstotal. Since cache refresh only reparses files whosemtimechanged, this keeps the new behaviour affordable while avoiding repeated full-vault cost on unchanged notes.