Skip to content

fix: tag search parsing and shell-safe ripgrep globs#4

Merged
jonathanchu merged 2 commits into
jonathanchu:mainfrom
guitmz:fix-rg-tags
May 7, 2026
Merged

fix: tag search parsing and shell-safe ripgrep globs#4
jonathanchu merged 2 commits into
jonathanchu:mainfrom
guitmz:fix-rg-tags

Conversation

@guitmz

@guitmz guitmz commented May 6, 2026

Copy link
Copy Markdown
Contributor

This fixes the tag search flow so tags behave the way Grove documents and users expect.

  • parse inline #hashtags into note metadata, not just #+filetags:
  • merge inline hashtags with #+filetags: without duplicates
  • normalize tag input in grove-search-tag
  • escape tag input before building the ripgrep regex
  • quote --glob='*.org' in shell-built ripgrep commands so fallback search/backlink commands work correctly under zsh

@jonathanchu

Copy link
Copy Markdown
Owner

Thanks @guitmz ! Great catches here. These are definite bugs I did not catch, much appreciated!

One small note, I don't have ERT workflows in GitHub Actions yet but that will be something to add up next. Happy to merge as-is though. Thank you again!

@jonathanchu jonathanchu merged commit 950e00c into jonathanchu:main May 7, 2026
2 checks passed
@guitmz guitmz deleted the fix-rg-tags branch May 7, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants