fix: tag search parsing and shell-safe ripgrep globs#4
Merged
Conversation
Owner
|
Thanks @guitmz ! Great catches here. These are definite bugs I did not catch, much appreciated! One small note, I don't have ERT workflows in GitHub Actions yet but that will be something to add up next. Happy to merge as-is though. Thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the tag search flow so tags behave the way Grove documents and users expect.
#hashtagsinto note metadata, not just#+filetags:#+filetags:without duplicatesgrove-search-tag--glob='*.org'in shell-built ripgrep commands so fallback search/backlink commands work correctly under zsh