fix(scripts): address retirement scan review findings

[jonathan-vella]

Description

Addresses all Copilot review findings raised after #672 merged.

Related Issue

Follow-up to #672.

Type of Change

• Documentation update
• Bug fix
• Refactoring (no functional changes)

Token / latency impact (Plan 01 Phase 5)

This change affects input-token budget / per-call latency:

• NO

Workflow Used

• Direct implementation (simple change)

Changes Made

• Correct deeply nested authentication-reference links.
• Shorten validation-reference table rows and clarify completed-plan approval wording.
• Remove a repository-specific CODEOWNER assertion.
• Use set membership for tracked-path reference lookups.

Testing Performed

• node --test tools/tests/audit-retirement-candidates.test.mjs
• npm run validate:retirement-scan
• npm run lint:md
• Prettier, ESLint, link checks, and git diff --check

Pre-Submission Checklist

• PR touches fewer than 50 files
• Commit message follows conventional commits
• Review conversations on feat: add whole-repository retirement scan #672 are resolved
• Markdown linting passes
• Internal links verified
• No hardcoded secrets or sensitive data

Additional Notes

All Copilot threads on #672 report resolved.

[Copilot]

🟡 Changes recommended

One documentation line in the validation reference is now ambiguous about which parts of validate:all are cache-aware and should be clarified.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR follows up on the whole-repository retirement scan work by tightening wording and link correctness, relaxing a repository-specific ownership assertion, and improving the retirement reference scan’s lookup performance.

Changes:

• Fix relative links to the Entra authentication best-practices reference in Service Bus Function recipe templates.
• Refine retirement-scan and validator documentation wording in the completed exec plan and validation reference docs.
• Improve candidateReferences() performance by using set membership, and adjust the ownership test to avoid a repo-specific CODEOWNERS assumption.

File summaries

File	Description
tools/tests/exec-plans/completed/whole-repo-retirement-scan-2026-08-27.md	Clarifies completion criteria wording around human approval for retirement actions.
tools/tests/audit-retirement-candidates.test.mjs	Removes repository-specific CODEOWNER assertion; now checks for non-empty ownership coverage.
tools/scripts/audit-retirement-candidates.mjs	Replaces repeated array includes() checks with Set membership for tracked-path lookups.
site/src/content/docs/reference/validation-reference.md	Shortens/adjusts validator table wording (one line still reads ambiguously about caching).
.github/skills/azure-prepare/references/services/functions/templates/recipes/servicebus/source/python.md	Fixes deep relative link to auth best practices reference.
.github/skills/azure-prepare/references/services/functions/templates/recipes/servicebus/source/powershell.md	Fixes deep relative link to auth best practices reference.
.github/skills/azure-prepare/references/services/functions/templates/recipes/servicebus/source/java.md	Fixes deep relative link to auth best practices reference.
.github/skills/azure-prepare/references/services/functions/templates/recipes/servicebus/source/dotnet.md	Fixes deep relative link to auth best practices reference.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.