fix: wrap string throws in Exception classes to comply with Dart linting rules - #3462
Open
Aniketkhote wants to merge 5 commits into
Open
fix: wrap string throws in Exception classes to comply with Dart linting rules#3462Aniketkhote wants to merge 5 commits into
Aniketkhote wants to merge 5 commits into
Conversation
…ing rules - Wrap all string throws in Exception() across multiple files - Make ObxError extend Exception instead of plain class - Update test expectations from String to Exception - Fix test logic in Get.delete test by uncommenting Get.put line This fixes all linting warnings about throwing instances that don't extend Exception or Error.
…ecycle bug" This reverts commit f764dc7.
- Extract ObxError class to lib/get_common/obx_error.dart - Make ObxError implement Exception to satisfy Dart linting rules - Remove commented-out dead code in list_notifier.dart - Add null safety assertions to addListenerId() and disposeId()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: wrap string throws in Exception classes to comply with Dart linting rules
This fixes all linting warnings about throwing instances that don't extend Exception or Error.