fix: update to vc-data-model v1.0 - #4
Open
PeterTheOne wants to merge 1 commit into
Open
Conversation
chunningham
approved these changes
Nov 6, 2020
chunningham
left a comment
chunningham
left a comment
Contributor
There was a problem hiding this comment.
looks good, will merge after confirming this is all that is needed
Contributor
|
Hello @PeterTheOne |
Author
|
@mnzaki I can sign my commits but how do I sign the CLA? |
issued -> issuanceDate claim -> credentialSubject jolocom/jolocom-lib#393
PeterTheOne
force-pushed
the
vc-data-model-v1
branch
from
March 14, 2021 11:24
f5da46f to
3ba70c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issued->issuanceDateclaim->credentialSubjectI'm not sure if other changes are also needed, maybe also something related to signature/proof?
see: jolocom/jolocom-lib#393