Fix hg2 (support for Matlab >= 2014b) - #10
Open
adhusch wants to merge 2 commits into
Open
Conversation
added 2 commits
August 4, 2017 11:25
Fix Incompatible Assignments (Matlab 2016b)
Workaround for missing VertexNormals as proposed at file exchange discussion. (Note: It seems that ‘VertexNormals’ are only calculated in the new graphics system when a *light* is present *and* that this process is asynchronous which makes it quite hart to predict when ‘VertexNormals’ could be assumed set or not)
Author
|
Known Issues: Textured Objects still don't work for me (tested with Matlab "topo" demo dataset) e2ccbbc (setting VertexNormals to Vertices) should be considered a workaround not a fix. For a proper fix the normals should be calculated in some other way (e.g. using "own" code instead of trying to get them from a matlab object). The results look okay with the workaround but lighting might be suboptimal without correct normal. Consider: https://de.mathworks.com/matlabcentral/fileexchange/24330-patch-normals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matlab handle graphics 2 support (tested with 2016b)