feat: add ROCm GPU support alongside CUDA#104
Open
alexhegit wants to merge 2 commits into
Open
Conversation
Add scripts/setup-rocm.sh to create a separate .venv-rocm with ROCm 7.2 PyTorch, and Makefile targets (rocm-*) for test/lint/format in the ROCm environment. The two venvs coexist independently.
Owner
|
Hi @alexhegit thank you for contributing. I realize I don't have a contribution guide since this project is still very early on, but I look forward to integrating your proposed changes. One thought I have off the bat is, why not bundle this as an extra to be installed (to the effect of so101-nexus[rocm])? Also, I would prefer to avoid install scripts. I use uv in the first place so that it is simple to run teleop without even having to install this environment. I will create an issue to track this and figure out how to better integrate ROCm support, if you are open to this. |
Owner
|
@alexhegit I did some work on this branch to support ROCm. Would you mind checking it out to see if that is sufficient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ROCm 7.2 GPU support so AMD GPU users can develop and test without conflicting with the default CUDA environment.
Changes
scripts/setup-rocm.sh: Creates.venv-rocmwith ROCm 7.2 PyTorch usinguv pip install --torch-backend rocm7.2 --force-reinstallto prevent CUDA torch from being pulled in as a transitive dependency.Makefile: Addedrocm-*targets (rocm-sync,rocm-test,rocm-test-warp,rocm-format,rocm-lint,rocm-typecheck) that run against.venv-rocm.Usage
Two venvs (
.venvand.venv-rocm) coexist independently.