Keep the map Confirm button beneath the order options sheet - #1400
Merged
Merged
Conversation
The Confirm button's wrapper used z-[1000], which painted it above the mobile order options bottom sheet (z-50). It only needs to sit above the map canvas, which is its own isolated stacking context, so z-10 suffices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y9qBhhFYZaUPJKjPRoFKv6
Contributor
Screenshot diff0 screens changed of 276 captured. No visual differences found. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
A player reported this on mobile: after tapping a unit on the map screen, the floating Confirm (n/m) button showed on top of the Hold / Move / Support options sheet and hid part of it.
Cause: the Confirm button's wrapper in
MapScreen.tsxusedz-[1000]. On mobile,FloatingMenushows the order options in aSheet, and the sheet's overlay and content are bothz-50(components/ui/sheet.tsx). Nothing between the wrapper and the page root creates a stacking context, so 1000 beat 50 and the button was painted over the sheet.The fill toggle next to it also uses
z-[1000], but it stays under the sheet. It sits insideGameMapCanvas'sisolation: isolatecontainer, so its z-index only counts inside the map.Fix: the Confirm button only needs to sit above that isolated map container, so its wrapper now uses
z-10, the same valueGameMap's province banner uses. It still floats over the map when no sheet is open, and the sheet's overlay now dims it and the sheet covers it.Reproduction
I reproduced this in headless Chromium at 390×844 against the MSW mocks. The mock
/options/response is empty, so for the screenshots only I gave theactive-movementfixture some order options for England's army in Liverpool. That change is not committed. I then tapped Liverpool on the map.Screenshots
Before and after at 390×844, taken right after tapping A Liverpool:
This session has no API for uploading GitHub attachments, so the images were captured but still need to be dragged in here. With the sheet closed, the button still shows above the map, bottom right, next to the fill toggle.
The
Screenshot Diffworkflow won't show this change: it only captures static screens, and the sheet opens only after tapping a unit.Checklist
/review-pragainst this PR in Claude Code and addressed (or responded to) its findings — one-class changeMapScreen.test.tsxpasses, and so do eslint andnpx tsc -b --noEmit.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y9qBhhFYZaUPJKjPRoFKv6
Generated by Claude Code