Fix dataset map multiprocessing and PIL image byte loading - #1
Open
Vedant-K1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running the fine-tuning script and hit a couple of roadblocks... specifically running completely out of system RAM, and the inference test crashing on certain datasets. I've pushed a few fixes for this.
RAM OOM during dataset preparation
When running map() on the datasets, it was hoarding memory and eventually crashing my setup.
Fix: I added num_proc to speed things up with multiprocessing, but more importantly, I added writer_batch_size=75. This forces the datasets library to flush to disk regularly, which keeps the system RAM usage under control.
Inference test crashing on raw byte images
If a HuggingFace dataset returns images as raw byte dicts instead of PIL Images, the pre/post-training inference test fails because the processor expects a PIL Image.
Fix: Added a quick check to convert raw byte streams into RGB PIL Images using io.BytesIO.