Repository navigation
Add uv project manifest (pyproject.toml + uv.lock) - #170
Merged
Merged
Conversation
Mirrors conversion/requirements.txt pins as a uv-managed virtual project (package=false) so `uv sync` / `uv run` provide a reproducible env for the conversion toolkit without changing the existing pip workflow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dokterbob
marked this pull request as ready for review
June 18, 2026 10:50
john-rocky
added a commit
that referenced
this pull request
Oct 2, 2026
The manifest added in #170 carried the pplx-embed branch's project name and description; main does not contain that branch. Pins are unchanged: the lock differs only in the project name, and `uv lock --check` passes.
Owner
|
Thanks for the uv manifest, Mathijs, and sorry for the long wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a uv project manifest so the conversion toolkit has a reproducible, locked environment.
pyproject.tomlmirrors the existingconversion/requirements.txtpins (coremltools 9, torch 2.11, transformers 5.5, …) as a virtual project ([tool.uv] package = false) — it manages the env only, it does not build/install the flatconversion/scripts as a wheel.uv.lockpins the full resolved graph.This is purely additive:
python -m venv && pip install -r conversion/requirements.txtkeeps working unchanged;uv sync/uv run …is just an alternative for those who want it. Kept as a separate PR from the pplx-embed feature so it can be accepted/declined independently.This will dramatically accelerate the installation time and facilitate dependency management. As a matter of fact, I would recommend removing requirements.txt and going full-on for uv.