optionally specify the repo to reserve#10
Open
yzAlvin wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
thanks for this tool, (and adding it to oculo)
I am proposing this internally on our fork, but thought I could raise it as an upstream PR too (but feel free to reject this very specific use case 😛)
Use-case
we still use it a bunch, one slight grievance i am bumping into as we expand the number of products + repos is that when we reserve
staging-aufor example, all CI across repos that fetch reservations recognise that environment as reservedExample:
oculoreserves staging-au for 2hfoolooks at reservations and sees thestaging-auenvironment is reserved so doesnt continuefoois separate tooculo, deployingfooto staging-au would not affectoculoThe opposite applies too
Idea
so I think adding a way to specify the repo is helpful for this case, so the
foopipeline only cares aboutfooreservationsAlso considered maybe its not
repobutproduct, so a collection of pipelines can care about a specific reservation, but i think repo is more flexibleUsage example:
@reservebot demo-au now 1h testing new feature --repo my-appIt does not affect any of the existing commands, just adds
--repo <some-string>