Skip to content

optionally specify the repo to reserve#10

Open
yzAlvin wants to merge 3 commits into
joffotron:masterfrom
yzAlvin:master
Open

optionally specify the repo to reserve#10
yzAlvin wants to merge 3 commits into
joffotron:masterfrom
yzAlvin:master

Conversation

@yzAlvin

@yzAlvin yzAlvin commented Jun 4, 2025

Copy link
Copy Markdown

Hello 👋

thanks for this tool, (and adding it to oculo)
I am proposing this internally on our fork, but thought I could raise it as an upstream PR too (but feel free to reject this very specific use case 😛)

Use-case

we still use it a bunch, one slight grievance i am bumping into as we expand the number of products + repos is that when we reserve staging-au for example, all CI across repos that fetch reservations recognise that environment as reserved

Example:

  • oculo reserves staging-au for 2h
  • foo looks at reservations and sees the staging-au environment is reserved so doesnt continue
    • foo is separate to oculo, deploying foo to staging-au would not affect oculo

The opposite applies too

Idea

so I think adding a way to specify the repo is helpful for this case, so the foo pipeline only cares about foo reservations

Also considered maybe its not repo but product, so a collection of pipelines can care about a specific reservation, but i think repo is more flexible

Usage example: @reservebot demo-au now 1h testing new feature --repo my-app

It does not affect any of the existing commands, just adds --repo <some-string>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant